-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Bump Gymnasium to 0.28.1 #35698
Changes from 65 commits
9dd8b29
5e860cd
3189e30
bd070e5
fbedf59
7402830
9d2e601
03e3c4b
98506e3
0f39209
0affa2a
c925e59
06e78e1
ecce074
65b2eec
a5bba3c
68f3cb5
74d4461
635ab9c
4f5ef24
f5ecaa6
cbc22f3
5833a90
acaa683
829d290
7842ff9
b95a0a5
f926316
721cfc9
58d7b11
78cd2b6
859d999
4d20fa2
87f38b7
f8c4c71
866fec3
c3ce9c9
7c41ef6
5ef2b8a
988980d
00aba6c
606c69c
3dda88e
37fbd31
05085c6
873e307
e984149
4caebe0
ed5928b
fe49364
b8f4fad
f24f94c
f80ceee
ed2ccc2
18baa94
2b8ebef
43fa608
10975a2
59fd88d
80ea98e
d113b64
b8183ca
f094723
70c71e5
264c836
ab7cab2
4ce8498
5536b4b
51d53f0
d2c77d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ | |
"To run the application, first install some dependencies.\n", | ||
"\n", | ||
"```bash\n", | ||
"pip install gymnasium[atari] gym==0.26.2\n", | ||
"pip install gymnasium[atari]==0.28.1\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curious, why did this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. gymnasium 0.26.2 did not come with ALE prepackaged I believe; that's why we were doing this as well as the workaround where we we using ALE environments from gym through the gymnasium->gym wrapper e.g. |
||
"```\n", | ||
"\n", | ||
"At the moment, on a large machine with 64 physical cores, computing an update\n", | ||
|
@@ -292,7 +292,7 @@ | |
"@ray.remote\n", | ||
"class RolloutWorker(object):\n", | ||
" def __init__(self):\n", | ||
" self.env = gym.make(\"GymV26Environment-v0\", env_id=\"ALE/Pong-v5\")\n", | ||
" self.env = gym.make(\"ALE/Pong-v5\")\n", | ||
"\n", | ||
" def compute_gradient(self, model):\n", | ||
" # Compute a simulation episode.\n", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,7 +162,7 @@ For example, for manipulating your env's observations or rewards, do: | |
|
||
.. code-block:: python | ||
|
||
import gym | ||
import gymnasium as gym | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bug fix |
||
from ray.rllib.utils.numpy import one_hot | ||
|
||
class OneHotEnv(gym.core.ObservationWrapper): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2937,7 +2937,7 @@ py_test( | |
) | ||
|
||
py_test( | ||
name = "tests/test_supported_spaces_ppo_no_preproceesor_gpu", | ||
name = "tests/test_supported_spaces_ppo_no_preprocessor_gpu", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I litteraly can not see the difference here. Is this a git error? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. preproceesor vs preprocessor :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NICE Catch maaaan! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Artur and I have the same visual capacity :) It's clear that we are old duuuuudes :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lol There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whaaat? If you two are old, then what am I??! :D |
||
main = "tests/test_supported_spaces.py", | ||
tags = ["team:rllib", "gpu", "no_cpu"], | ||
size = "large", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import gym | ||
import gymnasium as gym | ||
import unittest | ||
|
||
import ray | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this logic to
install-ml-dependencies.sh