Skip to content

Update arrow to reduce plasma IPCs. #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertnishihara merged 13 commits into from
Dec 15, 2018
Merged

Update arrow to reduce plasma IPCs. #3497

robertnishihara merged 13 commits into from
Dec 15, 2018

Conversation

@pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Dec 8, 2018

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 8, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9845/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 8, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9847/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 12, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9978/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10004/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10003/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10006/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10005/
Test FAILed.

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Dec 13, 2018

jenkins retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10008/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10028/
Test FAILed.

robertnishihara
robertnishihara reviewed Dec 14, 2018
View reviewed changes
src/ray/object_manager/object_store_notification_manager.cc Outdated
: store_client_(), socket_(io_service) {
ARROW_CHECK_OK(store_client_.Connect(store_socket_name.c_str(), "",
plasma::kPlasmaDefaultReleaseDelay));
ARROW_CHECK_OK(store_client_.Connect(store_socket_name.c_str(), "", 0));
Copy link
Collaborator

@robertnishihara robertnishihara Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the release delay argument

src/ray/object_manager/test/object_manager_stress_test.cc Outdated
// connect to stores.
ARROW_CHECK_OK(client1.Connect(store_id_1, "", plasma::kPlasmaDefaultReleaseDelay));
ARROW_CHECK_OK(client2.Connect(store_id_2, "", plasma::kPlasmaDefaultReleaseDelay));
ARROW_CHECK_OK(client1.Connect(store_id_1, "", 0));
Copy link
Collaborator

@robertnishihara robertnishihara Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the release delay argument. same everywhere else.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10031/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 14, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10032/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 14, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10051/
Test FAILed.

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Dec 14, 2018

jenkins retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10052/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 14, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10053/
Test FAILed.

@robertnishihara robertnishihara changed the title Reduce plasma IPCs Update arrow to reduce plasma IPCs. Dec 15, 2018
@robertnishihara robertnishihara merged commit b3bf608 into ray-project:master Dec 15, 2018
@robertnishihara robertnishihara deleted the plasma-ipc branch December 15, 2018 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcmoritz @AmplabJenkins @robertnishihara