[Datasets] Require preserving order if plan has Zip or Sort stage #32860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
clarkzinzow,
ericl,
jianoaix,
jjyao and
scv119
as code owners
ericl
approved these changes
Feb 27, 2023
c21
added
the
tests-ok
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…y-project#32860) This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4. Signed-off-by: Jack He <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…y-project#32860) This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4. Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…y-project#32860) This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…y-project#32860) This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…y-project#32860) This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4. Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is to require preserving order when plan has either Zip or Sort stage. This applies to both bulk and streaming executor. Given streaming executor is not preserving order by default, this PR is more of a bugfix to prevent regression. A followup PR is to add the corresponding check inside optimizer (probably as an optimizer rule). Don't want to couple the change of optimizer here, because we want to enable streaming executor by default in 2.4.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.