[core] Move checkalive to NodeInfoManager in GCS. #29389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
fishbone
requested review from
wuisawesome,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz,
raulchen and
scv119
as code owners
fishbone
changed the title
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
rkooo567
approved these changes
Oct 18, 2022
|
@wuisawesome @ericl could one of you give a look as the code owner? |
Signed-off-by: Yi Cheng <[email protected]>
fishbone
force-pushed
the
move-check-alive-to-node-mgr
branch
from
d1b6ffd to
6c5b35b
Compare
Signed-off-by: Yi Cheng <[email protected]>
fishbone
force-pushed
the
move-check-alive-to-node-mgr
branch
from
6c5b35b to
ddfdd78
Compare
scv119
approved these changes
Oct 18, 2022
|
mac failure unrelated |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
The CheckAlive is used by the dashboard and ray health-check to check the healthiness of the ray cluster and raylet. It's implemented in HeartbeatManager which means if we disable heartbeat manager, it's not going to work. Heartbeat manager should only do the heartbeat and health check and no other things. So this feature fit into NodeInfoManager better. This PR just move this feature to NodeInfoManager and still keep the semantics of the rpc. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The CheckAlive is used by the dashboard and
ray health-checkto check the healthiness of the ray cluster and raylet.It's implemented in HeartbeatManager which means if we disable heartbeat manager, it's not going to work.
Heartbeat manager should only do the heartbeat and health check and no other things. So this feature fit into NodeInfoManager better.
This PR just move this feature to NodeInfoManager and still keep the semantics of the rpc.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.