Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Test ray core doc code #27334

Merged
merged 8 commits into from
Aug 3, 2022
Merged

[Doc] Test ray core doc code #27334

merged 8 commits into from
Aug 3, 2022

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 1, 2022

Signed-off-by: Jiajun Yao [email protected]

Why are these changes needed?

  • Currently not all code under ray-core/doc_code is covered by CI.
  • tf_example.py and torch_example.py are not used anywhere.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Test ray core doc code
7cfc8c7 
Signed-off-by: Jiajun Yao <[email protected]>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 2, 2022
@jjyao
up
c61820e 
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao jjyao added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Aug 3, 2022
@jjyao
Copy link
Collaborator Author

jjyao commented Aug 3, 2022

Failed tests are unrelated.

@jjyao jjyao merged commit 8b7e4ac into ray-project:master Aug 3, 2022
@jjyao jjyao deleted the jjyao/doc_code branch August 3, 2022 03:51
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@jjyao
[Doc] Test ray core doc code (ray-project#27334)
e1ac191 
- Currently not all code under ray-core/doc_code is covered by CI.
- tf_example.py and torch_example.py are not used anywhere.

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@pcmoritz pcmoritz Awaiting requested review from pcmoritz

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@dmatrix dmatrix Awaiting requested review from dmatrix

@sriram-anyscale sriram-anyscale Awaiting requested review from sriram-anyscale

Assignees

@ericl ericl

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @ericl