-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add OPE Learning Tests #27154
Merged
Merged
+782
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
kouroshHakha
reviewed
Aug 1, 2022
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: rapotdar <[email protected]>
kouroshHakha
approved these changes
Aug 2, 2022
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate learning tests for FQE, DM, and DR, and downgrade the test_ope.py to just a compilation test (Potentially, we could even drop it completely or just keep the ope_in_algo part).
Some of these tests might be slightly redundant e.g.
test_dm
andTestOPE.test_dm
hit most of the same test cases, but the wholeestimators/tests/
folder takes about five minutes to run anyway, plus I think we should keep thetest_ope
CartPole compilation tests for a sanity check because the gridworld is a little too easy.Related issue number
closes #26546
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.