Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add OPE Learning Tests #27154

Merged
merged 70 commits into from
Aug 3, 2022
Merged

Conversation

Rohan138
Copy link
Contributor

@Rohan138 Rohan138 commented Jul 28, 2022

Add separate learning tests for FQE, DM, and DR, and downgrade the test_ope.py to just a compilation test (Potentially, we could even drop it completely or just keep the ope_in_algo part).

Some of these tests might be slightly redundant e.g. test_dm and TestOPE.test_dm hit most of the same test cases, but the whole estimators/tests/ folder takes about five minutes to run anyway, plus I think we should keep the test_ope CartPole compilation tests for a sanity check because the gridworld is a little too easy.

Related issue number

closes #26546

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Rohan138 added 30 commits July 19, 2022 11:12
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: rapotdar <[email protected]>
@richardliaw richardliaw merged commit 5b6a58e into ray-project:master Aug 3, 2022
@Rohan138 Rohan138 mentioned this pull request Aug 3, 2022
7 tasks
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] Write learning tests for OPE methods
3 participants