Add GPU info to new dashboard #27074
Conversation
Have first node be default expanded Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
|
This is great :) |
|
@alanwguo is it possible to assign someone else as well for reviewing the frontend code? I can review briefly, but I am not confident I can do a quality review. (only superficial one is possible from my end) |
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
| node: NodeDetail; | ||
| }) => { | ||
| const workerGRAMEntries = (node.gpus ?? []) | ||
| .map((gpu, i) => { |
There was a problem hiding this comment.
use reduce() to handle workerGRAMEntries instead of map().filter()
There was a problem hiding this comment.
What's the reason for the suggestion? I find map + filter to be easier to understand (better for code maintainability) than reduce functions.
|
pick for 2.0.0 but not an rc0 blocker |
|
One question: What's the reason why GPU is N/A when there's GRAM available? |
Only show N/A if gpu utilization is undefined Signed-off-by: Alan Guo <[email protected]>
That was a bad screenshot. This is the the normal case: |
|
@alanwguo do you think I can merge it without further frontend review? (should we ask someone like Shawn?) |
shawn is reviewing |
| export const NodeGPUView = ({ node }: { node: NodeDetail }) => { | ||
| return ( | ||
| <div style={{ minWidth: GPU_COL_WIDTH }}> | ||
| {node.gpus !== undefined && node.gpus.length !== 0 ? ( |
There was a problem hiding this comment.
nit: you could do node.gpus?.length instead of node.gpus !== undefined && node.gpus.length !== 0
There was a problem hiding this comment.
Unfortunately, the typescript compiler isn't smart enough to realize node.gpus is not null in the next line when node.gpus.length is not null.
Signed-off-by: Alan Guo <[email protected]>
|
Lmk when it is ready to merge! |
|
@rkooo567 please merge anytime |
Support a GPU column for the new dashboard Have first node be default expanded Signed-off-by: Alan Guo [email protected] fixes #13889 Addresses comment from #26996
Support a GPU column for the new dashboard Have first node be default expanded Signed-off-by: Alan Guo [email protected] fixes #13889 Addresses comment from #26996
Support a GPU column for the new dashboard Have first node be default expanded Signed-off-by: Alan Guo [email protected] fixes ray-project#13889 Addresses comment from ray-project#26996 Signed-off-by: Stefan van der Kleij <[email protected]>
Have first node be default expanded
Signed-off-by: Alan Guo [email protected]
Why are these changes needed?
Related issue number
fixes #13889
Addresses comment from #26996
Checks
scripts/format.shto lint the changes in this PR.