Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import sort rest of autoscaler #25796

Merged
merged 4 commits into from
Jun 15, 2022
Merged

import sort rest of autoscaler #25796

merged 4 commits into from
Jun 15, 2022

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Jun 15, 2022

Why are these changes needed?

Continue to import sort the rest of autoscaler

Related issue number

#25678

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarng clarng marked this pull request as ready for review June 15, 2022 05:31
DmitriGekhtman
DmitriGekhtman approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks benign to me.

@DmitriGekhtman
Copy link
Contributor

@ericl @richardliaw @edoakes I think we need a stamp from at least one of you.

@DmitriGekhtman
Copy link
Contributor

Lint is known broke at the moment, unfortunately.

@DmitriGekhtman DmitriGekhtman merged commit 1a5f427 into master Jun 15, 2022
@DmitriGekhtman DmitriGekhtman deleted the cn_sort_as branch June 15, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriGekhtman DmitriGekhtman DmitriGekhtman approved these changes

@richardliaw richardliaw richardliaw approved these changes

@wuisawesome wuisawesome wuisawesome approved these changes

@ericl ericl Awaiting requested review from ericl

@edoakes edoakes Awaiting requested review from edoakes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clarng @DmitriGekhtman @wuisawesome @richardliaw