[Datasets] [Out-of-Band Serialization: 3/3] Add out-of-band serialization. #23932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
added
the
@author-action-required
clarkzinzow
force-pushed
the
datasets/feat/add-out-of-band-serialization
branch
from
05bd7fb to
46a2d1a
Compare
clarkzinzow
force-pushed
the
datasets/feat/add-out-of-band-serialization
branch
from
46a2d1a to
3a87dcc
Compare
Contributor
Author
|
@jianoaix this is ready for review! |
jianoaix
reviewed
Apr 23, 2022
Contributor
jianoaix
left a comment
jianoaix
left a comment
There was a problem hiding this comment.
Glad we move to the last PR to wrap it up!
…ink for remote function handle serialization issue.
jianoaix
reviewed
Apr 24, 2022
Contributor
jianoaix
left a comment
jianoaix
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nits
jianoaix
approved these changes
Apr 25, 2022
ericl
approved these changes
Apr 25, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for out-of-band serialization of datasets, i.e. for serializing and deserializing datasets across Ray clusters. This PR is the final PR in a set to add such support (3/3). See the mono PR for more context.
Checks
scripts/format.shto lint the changes in this PR.