[autoscaler] Should use internal IP for ssh#2209
Merged
richardliaw merged 4 commits intoray-project:masterfrom Jun 8, 2018
Merged
[autoscaler] Should use internal IP for ssh#2209richardliaw merged 4 commits intoray-project:masterfrom
richardliaw merged 4 commits intoray-project:masterfrom
Conversation
Contributor
Author
|
Tested and this seems to work |
robertnishihara
approved these changes
Jun 8, 2018
|
Test PASSed. |
|
Test PASSed. |
Contributor
|
Test failures look unrelated. |
|
Just tried the latest build and it seems to work, thanks! I did notice that
my EC2 instances no longer get named and the ray:etc tags don't get
assigned. Not sure if that's specific to this build, something that changed
since ray 0.3.1, or another issue entirely.
…On Fri, Jun 8, 2018 at 1:09 AM Richard Liaw ***@***.***> wrote:
Merged #2209 <#2209>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2209 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABSUn3m0WBnMx7LPNsiKEEK47F2n8qNtks5t6jEigaJpZM4UfUhM>
.
|
Contributor
Author
|
Oh, the tag name change is due to a recent PR to support the GCP labeling
scheme as well. I guess on unintentional side effect is it breaks AWS
names. I'll see if that can be fixed.
…On Fri, Jun 8, 2018, 10:31 AM NP Young ***@***.***> wrote:
Just tried the latest build and it seems to work, thanks! I did notice that
my EC2 instances no longer get named and the ray:etc tags don't get
assigned. Not sure if that's specific to this build, something that changed
since ray 0.3.1, or another issue entirely.
On Fri, Jun 8, 2018 at 1:09 AM Richard Liaw ***@***.***>
wrote:
> Merged #2209 <#2209>.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#2209 (comment)>, or mute
> the thread
> <
https://github.com/notifications/unsubscribe-auth/ABSUn3m0WBnMx7LPNsiKEEK47F2n8qNtks5t6jEigaJpZM4UfUhM
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2209 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA6SlnPJgLxf6QpOzUisiRneIAeSsNCks5t6rT9gaJpZM4UfUhM>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As reported on the dev list, the external ip is not always accessible from the head node.
@richardliaw