Skip to content

Conversation

@alok
Copy link
Contributor

@alok alok commented May 17, 2018

What do these changes do?

See #1971. This is a cleaned up version meant to apply cleanly onto the
current master branch.

In summary:

  1. Makes yapf actually use the existing .style.yapf file like it's supposed to
  2. runs linting in parallel
  3. More robust to weird shell misfeatures like word expansion
  4. Adds linting to pandas and RLlib since @robertnishihara mentioned we should probably start doing that at some point. Since this PR doesn't actually change the files, we can do the lint in a follow-up PR (like Python linting fixes. #2076 did).

Related issue number

#1971

@richardliaw
Copy link
Contributor

So no other linting changes will be applied in this PR?

@alok
Copy link
Contributor Author

alok commented May 17, 2018

No, that's it. I just applied the actual PR changes, and the additional one you wanted.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5452/
Test PASSed.

@alok alok closed this May 19, 2018
@alok alok deleted the yapf-take-3 branch May 21, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants