Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset] Bump numpy >=1.20 dependency #20374

Merged
merged 3 commits into from
Nov 15, 2021
Merged

[Dataset] Bump numpy >=1.20 dependency #20374

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
073754d
done?
Nov 15, 2021
52d30ac
.
Nov 15, 2021
11e7e23
Merge branch 'master' of github.com:ray-project/ray into numpy_versio…
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/base-deps/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ RUN sudo apt-get update -y && sudo apt-get upgrade -y \
&& $HOME/anaconda3/bin/pip install --no-cache-dir \
flatbuffers \
cython==0.29.23 \
numpy==1.19.5 \
# Necessary for Dataset to work properly.
numpy>=1.20 \
psutil \
blist \
# blist is needed for numpy (which is re-installed when ray is installed)
Expand Down
4 changes: 4 additions & 0 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ def get_packages(self):
],
}

if sys.version_info >= (3, 7):
# Numpy dropped python 3.6 support in 1.20.
setup_spec.extras["data"].append("numpy >= 1.20")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering what's the difference between data extras and https://github.com/ray-project/ray/blob/master/python/requirements/data_processing/requirements_dataset.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data extras is what's actually installed when you do pip install ray[data]. Those requirements files should be for additional ray developer add-ons.


# Ray Serve depends on the Ray dashboard components.
setup_spec.extras["serve"] = list(
set(setup_spec.extras["serve"] + setup_spec.extras["default"]))
Expand Down