Skip to content

[DataFrame] Refactor indexers and implement setitem #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devin-petersohn merged 2 commits into from
May 15, 2018
Merged

[DataFrame] Refactor indexers and implement setitem #2020

devin-petersohn merged 2 commits into from
May 15, 2018

Conversation

@simon-mo
Copy link
Contributor

@simon-mo simon-mo commented May 9, 2018

What do these changes do?

  • A re-write of indexing.py in dataframe module.
  • Implemented setitem methods
  • Implement DataFrameView class for efficient "View" structure

Refactor

indexing.py was refactored according to diagram below:
iloc_refactor

Related issue number

This closes PR #1995

@simon-mo simon-mo mentioned this pull request May 9, 2018
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented May 9, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5288/
Test PASSed.

devin-petersohn
devin-petersohn approved these changes May 12, 2018
View reviewed changes
Copy link
Member

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5354/
Test FAILed.

@devin-petersohn
Copy link
Member

devin-petersohn commented May 12, 2018

Jenkins, retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5355/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5371/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5375/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5388/
Test PASSed.

@devin-petersohn devin-petersohn merged commit 825c227 into ray-project:master May 15, 2018
@devin-petersohn
Copy link
Member

devin-petersohn commented May 15, 2018

Merged, thanks @simon-mo!

alok added a commit to alok/ray that referenced this pull request May 21, 2018
@alok
Merge branch 'master' into fix-a3c-torch
aeab1f3 
* master:
  Pin Pandas version for Travis to 0.22 (ray-project#2075)
  Fix python linting (ray-project#2076)
  [xray] Fix GCS table prefixes (ray-project#2065)
  Some tests for _submit API. (ray-project#2062)
  [rllib] Queue lib for python 2.7 (ray-project#2057)
  [autoscaler] Remove faulty assert that breaks during downscaling, pull configs from env (ray-project#2006)
  [DataFrame] Refactor indexers and implement setitem (ray-project#2020)
  [rllib]Update bc/policy.py (ray-project#2012)
@simon-mo simon-mo mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simon-mo @AmplabJenkins @devin-petersohn