-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[DataFrame] Implemented nunique, skew #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b2a830
implemented prod/product, modified declaration for sum, added pandas …
hsubbaraj f9c5faf
fixed tests
hsubbaraj 6d08249
removed test_analytics file
hsubbaraj f98ac8f
implemented nunique, skew
hsubbaraj ca17d36
fixed changes for nunique, skew
hsubbaraj 5761618
fixed nunique test
hsubbaraj 79971e5
added axis=1 test to skew
hsubbaraj bafb02e
flake8 issues
hsubbaraj bce1867
more flake8 issues
hsubbaraj 80bedb1
resolve some flake issues
kunalgosar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2149,11 +2149,9 @@ def test_nsmallest(): | |
| ray_df.nsmallest(None, None) | ||
|
|
||
|
|
||
| def test_nunique(): | ||
| ray_df = create_test_dataframe() | ||
|
|
||
| with pytest.raises(NotImplementedError): | ||
| ray_df.nunique() | ||
| @pytest.fixture | ||
| def test_nunique(ray_df, pandas_df): | ||
| assert(ray_df_equals_pandas(ray_df.nunique(), pandas_df.nunique())) | ||
|
|
||
|
|
||
| def test_pct_change(): | ||
|
|
@@ -2205,14 +2203,14 @@ def test_pow(): | |
| test_inter_df_math("pow", simple=False) | ||
|
|
||
|
|
||
| def test_prod(): | ||
| def test_prod(ray_df, pandas_df): | ||
|
||
| ray_df = create_test_dataframe() | ||
|
|
||
| with pytest.raises(NotImplementedError): | ||
| ray_df.prod(None) | ||
| ray_df.prod() | ||
|
|
||
|
|
||
| def test_product(): | ||
| def test_product(ray_df, pandas_df): | ||
| ray_df = create_test_dataframe() | ||
|
|
||
| with pytest.raises(NotImplementedError): | ||
|
|
@@ -2651,11 +2649,9 @@ def test_shift(): | |
| ray_df.shift() | ||
|
|
||
|
|
||
| def test_skew(): | ||
| ray_df = create_test_dataframe() | ||
|
|
||
| with pytest.raises(NotImplementedError): | ||
| ray_df.skew() | ||
| @pytest.fixture | ||
| def test_skew(ray_df, pandas_df): | ||
| assert(ray_df_equals_pandas(ray_df.skew(), pandas_df.skew())) | ||
|
|
||
|
|
||
| def test_slice_shift(): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test both axis here.