Skip to content

[DataFrame] Add direct pandas imports for MVP #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devin-petersohn merged 2 commits into from
May 9, 2018
Merged

[DataFrame] Add direct pandas imports for MVP #1960

devin-petersohn merged 2 commits into from
May 9, 2018

Conversation

@kunalgosar
Copy link
Contributor

@kunalgosar kunalgosar commented Apr 28, 2018 •
edited
Loading

This imports many functions that do not rely on custom behavior directly from pandas.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5097/
Test PASSed.

devin-petersohn
devin-petersohn reviewed May 2, 2018
View reviewed changes
python/ray/dataframe/__init__.py Outdated
Copy link
Member

@devin-petersohn devin-petersohn May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Index, MultiIndex, Series.

Copy link
Contributor Author

@kunalgosar kunalgosar May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kunalgosar
Copy link
Contributor Author

kunalgosar commented May 4, 2018

@devin-petersohn Added some additional imports as well not required for MVP, as discussed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5190/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5187/
Test PASSed.

@kunalgosar
Copy link
Contributor Author

kunalgosar commented May 4, 2018

Jenkins, retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5198/
Test FAILed.

@kunalgosar
Copy link
Contributor Author

kunalgosar commented May 4, 2018

Jenkins, retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5200/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5211/
Test FAILed.

@kunalgosar
Copy link
Contributor Author

kunalgosar commented May 4, 2018

Jenkins, retest this please

1 similar comment
@kunalgosar
Copy link
Contributor Author

kunalgosar commented May 4, 2018

Jenkins, retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 4, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5218/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5274/
Test PASSed.

@devin-petersohn devin-petersohn merged commit d2c193e into ray-project:master May 9, 2018
@devin-petersohn
Copy link
Member

devin-petersohn commented May 9, 2018

Merged, thanks @kunalgosar!

alok added a commit to alok/ray that referenced this pull request May 9, 2018
@alok
Merge branch 'master' into comps
329834e 
* master: (25 commits)
  [DataFrame] Add direct pandas imports for MVP (ray-project#1960)
  Make ActorHandles pickleable, also make proper ActorHandle and ActorC… (ray-project#2007)
  Expand local_dir in Trial init (ray-project#2013)
  Fixing ascii error for Python2 (ray-project#2009)
  [DataFrame] Implements df.update (ray-project#1997)
  [DataFrame] Implements df.as_matrix (ray-project#2001)
  [DataFrame] Implement quantile (ray-project#1992)
  [DataFrame] Impement sort_values and sort_index (ray-project#1977)
  [DataFrame] Implement rank (ray-project#1991)
  [DataFrame] Implemented prod, product, added test suite (ray-project#1994)
  [DataFrame] Implemented __setitem__, select_dtypes, and astype (ray-project#1941)
  [DataFrame] Implement diff (ray-project#1996)
  [DataFrame] Implemented nunique, skew (ray-project#1995)
  [DataFrame] Implements filter and dropna (ray-project#1959)
  [DataFrame] Implements df.pipe (ray-project#1999)
  [DataFrame] Apply() for Lists and Dicts (ray-project#1973)
  Clean up syntax for supported Python versions. (ray-project#1963)
  [DataFrame] Implements mode, to_datetime, and get_dummies (ray-project#1956)
  [DataFrame] Fix dtypes (ray-project#1930)
  keep_dims -> keepdims (ray-project#1980)
  ...
alok added a commit to alok/ray that referenced this pull request May 9, 2018
@alok
Merge branch 'master' into magic-methods
601e67b 
* master:
  [DataFrame] Add direct pandas imports for MVP (ray-project#1960)
  Make ActorHandles pickleable, also make proper ActorHandle and ActorC… (ray-project#2007)
  Expand local_dir in Trial init (ray-project#2013)
  Fixing ascii error for Python2 (ray-project#2009)
  [DataFrame] Implements df.update (ray-project#1997)
  [DataFrame] Implements df.as_matrix (ray-project#2001)
  [DataFrame] Implement quantile (ray-project#1992)
  [DataFrame] Impement sort_values and sort_index (ray-project#1977)
  [DataFrame] Implement rank (ray-project#1991)
  [DataFrame] Implemented prod, product, added test suite (ray-project#1994)
  [DataFrame] Implemented __setitem__, select_dtypes, and astype (ray-project#1941)
  [DataFrame] Implement diff (ray-project#1996)
  [DataFrame] Implemented nunique, skew (ray-project#1995)
  [DataFrame] Implements filter and dropna (ray-project#1959)
  [DataFrame] Implements df.pipe (ray-project#1999)
  [DataFrame] Apply() for Lists and Dicts (ray-project#1973)
alok added a commit to alok/ray that referenced this pull request May 11, 2018
@alok
Merge branch 'master' into trpo
e0da980 
* master:
  [DataFrame] Implement where (ray-project#1989)
  [DataFrame] Add direct pandas imports for MVP (ray-project#1960)
  Make ActorHandles pickleable, also make proper ActorHandle and ActorC… (ray-project#2007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kunalgosar @AmplabJenkins @devin-petersohn