Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightly] Add grpc based broadcasting into nightly test for decision_tree #19531

Merged
merged 8 commits into from
Oct 20, 2021

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Oct 19, 2021

Why are these changes needed?

Decision tree test used to fail with grpc broadcasting in gcs. This PR put it into the nightly test and run it every day for staging purposes to collect more data points.

Related issue number

#19438

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone changed the title Grpc broadcast [nightly] Add grpc based broadcasting into nightly test for decision_tree Oct 19, 2021
@fishbone fishbone marked this pull request as ready for review October 19, 2021 22:21
@fishbone fishbone assigned mwtian and unassigned ericl Oct 19, 2021
@rkooo567
Copy link
Contributor

Failing windows test (Windows::test_basic_client_mode) seems to be flaky in the master

@rkooo567 rkooo567 merged commit 7a9cedf into ray-project:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants