[workflow] fix workflow user metadata return when None is given #19356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
changed the title
Contributor
|
Do we have a test case to cover this one? The current CI doesn't fail so I think the test is not good enough? |
fishbone
added
the
@author-action-required
Contributor
Author
|
@iycheng added |
fishbone
approved these changes
Oct 13, 2021
Contributor
fishbone
left a comment
fishbone
left a comment
There was a problem hiding this comment.
LG! Waiting for test to finish.
fishbone
removed
the
@author-action-required
Contributor
|
Test failure not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Quick fix for metadata put. Currently when workflow-level metadata is not given, it will output
nulltouser_run_metadata.json, this fix will make it output{}.Related issue number
original issue: #17090
original PR: #19195
Checks
scripts/format.shto lint the changes in this PR.