[ray_client]: Monitor client stream errors #13386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
Jan 13, 2021
Contributor
ericl
left a comment
ericl
left a comment
There was a problem hiding this comment.
Can you add a test for this?
ericl
added
the
@author-action-required
barakmich
force-pushed
the
client_stream_errors
branch
from
2192fa7 to
dc893c0
Compare
Contributor
Author
|
Added test and rebased off of #13478 (so it's now dependant) as they share a bit of startup code. |
barakmich
removed
the
@author-action-required
barakmich
force-pushed
the
client_stream_errors
branch
from
dc893c0 to
2c1ac55
Compare
Contributor
Author
|
Rebased again so we're ready to go when the dependent PR gets in |
Contributor
|
Should be rebased now |
ericl
added
the
@author-action-required
Change-Id: I002e413fce18de221a1c6e961487d1c9aa00be59
Change-Id: I6296a2c8ad23f1296c218048fccbcce4222a94ef
Change-Id: Id2a3a49c4e6b61ca78356214408c7c873bcc1ee0
barakmich
force-pushed
the
client_stream_errors
branch
from
2c1ac55 to
f29d9fd
Compare
barakmich
removed
the
@author-action-required
Change-Id: Ie1fad3233482cea45471c527187263c47338e522
Contributor
Author
|
@ericl PTAL; I think the test failure is unrelated |
ericl
approved these changes
Jan 26, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
This reverts commit a53b28b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes the blocking bug for clients that have the server disconnect on them. Adds better connection monitoring in general.
Related issue number
Parallel to #13376
Closes #13353. (reopen or new bug if more issues come up)
Checks
scripts/format.shto lint the changes in this PR.