[Core] zero-copy serializer for pytorch #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be ok. I'll add more tests later. |
suquark
changed the title
suquark
changed the title
suquark
added
the
tests-ok
simon-mo
approved these changes
Nov 26, 2020
6 tasks
krfricke
pushed a commit
to krfricke/ray
that referenced
this pull request
Nov 28, 2020
This reverts commit 0a505ca
richardliaw
pushed a commit
that referenced
this pull request
Nov 28, 2020
suquark
added a commit
to suquark/ray
that referenced
this pull request
Nov 29, 2020
* zero-copy serializer for pytorch * address possible bottleneck * add tests & device support (cherry picked from commit 0a505ca)
|
The torch import in serialization_addons.py breaks our RLlib test (test_dependency_torch), which checks whether everything would still work, even if torch were not installed (e.g. for tf-only users). |
amogkam
added a commit
to amogkam/ray
that referenced
this pull request
Dec 1, 2020
…ct#12344)" (ray-project#12478)" This reverts commit 3f22448.
rkooo567
pushed a commit
that referenced
this pull request
Dec 1, 2020
6 tasks
|
@suquark any chance we can bring in back in? |
|
+1 this was a really cool feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When shifted from PyArrow, we lost zero-copy serialization for torch tensors. This PR not only recovers the zero-copy serialization, it also fixes several bugs in the original serializer.
Related issue number
Closes #4855
Closes #12317
Checks
scripts/format.shto lint the changes in this PR.