[tune] All examples to use ConcurrencyLimiter #10662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # python/ray/tune/suggest/bohb.py # python/ray/tune/suggest/dragonfly.py # python/ray/tune/suggest/nevergrad.py # python/ray/tune/suggest/skopt.py # python/ray/tune/suggest/zoopt.py
krfricke
approved these changes
Sep 9, 2020
Contributor
krfricke
left a comment
krfricke
left a comment
There was a problem hiding this comment.
Looks good, left minor comments
| config={ | ||
| "width": sample_from(lambda spec: 10 + int(90 * random.random())), | ||
| "height": sample_from(lambda spec: int(100 * random.random())) | ||
| "width": tune.randint(10, 90), |
Contributor
There was a problem hiding this comment.
nit: this would be randint(10, 100)
Should we also remove mode/metric from the scheduler and pass it to tune.run here?
Contributor
Author
There was a problem hiding this comment.
will do this in followup!
| mode="min", | ||
| max_t=400, | ||
| grace_period=60) | ||
| metric="mean_loss", mode="min", max_t=400, grace_period=60) |
Contributor
There was a problem hiding this comment.
We could also pass metric/mode to tune.run here
Contributor
Author
There was a problem hiding this comment.
will do this in followup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Closes #10270
Related issue number
Checks
scripts/format.shto lint the changes in this PR.