Skip to content

[Core] Logging improvements #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkooo567 merged 9 commits into from
Sep 9, 2020
Merged

[Core] Logging improvements #10625

rkooo567 merged 9 commits into from
Sep 9, 2020

Conversation

@wuisawesome
Copy link
Contributor

@wuisawesome wuisawesome commented Sep 7, 2020 •
edited
Loading

Why are these changes needed?

  • Don't print plasma related logs twice
  • Don't print resource override logs multiple times
  • Move retry logs to INFO
  • Move throttling logs to WARNING

Related issue number

#10585
#9692

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

ffbin
ffbin reviewed Sep 8, 2020
View reviewed changes
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 8, 2020
ffbin
ffbin approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ffbin ffbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkooo567 rkooo567 merged commit d9c68fc into ray-project:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffbin ffbin ffbin approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@barakmich barakmich

@rkooo567 rkooo567

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wuisawesome @ffbin @rkooo567 @barakmich