Revert "[api] Second round of 1.0 API changes: exceptions, num_return…#10415
Closed
rkooo567 wants to merge 1 commit intoray-project:masterfrom
Closed
Revert "[api] Second round of 1.0 API changes: exceptions, num_return…#10415rkooo567 wants to merge 1 commit intoray-project:masterfrom
rkooo567 wants to merge 1 commit intoray-project:masterfrom
Conversation
…_vals (ray-project#10377)" This reverts commit 2a20426.
ericl
approved these changes
Aug 29, 2020
Contributor
ericl
left a comment
ericl
left a comment
There was a problem hiding this comment.
Ah probably a bad conflict
Contributor
|
It might be easier just to fix forward btw |
Contributor
Author
|
@ericl Please go ahead if we can push the easy fix! |
Contributor
Author
|
I just thoguth since it is Fri, it might be better merging this now cuz I assume you'd like to take a break) |
Contributor
|
Ah you can try fixing if you want, it's probably some trivial thing.
…On Fri, Aug 28, 2020, 9:44 PM SangBin Cho ***@***.***> wrote:
I just thoguth since it is Fri, it might be better merging this now cuz I
assume you'd like to take a break)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10415 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSXACWNXLKXS4VO5OWLSDCBSHANCNFSM4QOYKGKA>
.
|
Contributor
Author
|
@ericl Yeah I think it is just some tests used num_return_vals instead of num_returns. I might not have time rn, so I will probably spend some time this weekends (and merge this for now)! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like this commit breaks all tests. https://github.com/ray-project/ray/runs/1044158725
…_vals (#10377)"
This reverts commit 2a20426.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.