Add option to disable profiling and task timeline#10414
Merged
stephanie-wang merged 1 commit intoray-project:masterfrom Aug 29, 2020
Merged
Add option to disable profiling and task timeline#10414stephanie-wang merged 1 commit intoray-project:masterfrom
stephanie-wang merged 1 commit intoray-project:masterfrom
Conversation
Contributor
|
Looks similar to this haha https://github.com/ray-project/ray/pull/9614/files |
Contributor
|
I think we now have a better reason to make it on and off! |
rkooo567
approved these changes
Aug 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
System event profiling can generate a lot of Redis data and load. This PR adds an option to disable event profiling completely. This can be controlled with the
enable_timelineparameter in the_system_config(default true).Related issue number
May mitigate #10234.
Checks
scripts/format.shto lint the changes in this PR.