[autoscaler] Add documentation for multi node type autoscaling#10405
Merged
ericl merged 14 commits intoray-project:masterfrom Aug 29, 2020
Merged
[autoscaler] Add documentation for multi node type autoscaling#10405ericl merged 14 commits intoray-project:masterfrom
ericl merged 14 commits intoray-project:masterfrom
Conversation
ericl
commented
Aug 28, 2020
|
|
||
| def debug_string(self, nodes: List[NodeID], | ||
| pending_nodes: Dict[NodeID, int]) -> str: | ||
| # TODO(ekl) take into account existing utilization of node resources. We |
| # node. This number should be >= 0. | ||
| min_workers: 0 | ||
|
|
||
| # The autoscaler will scale up the cluster to this target fraction of resource |
Contributor
There was a problem hiding this comment.
Suggested change
| # The autoscaler will scale up the cluster to this target fraction of resource | |
| # The autoscaler will scale up the cluster to this target fraction of CPU |
Not sure if this is accurate.
Contributor
Author
There was a problem hiding this comment.
It's actually resource usage, not CPU
Contributor
There was a problem hiding this comment.
Could we specify what resources are considered?
Contributor
Author
There was a problem hiding this comment.
I've updated this in the paragraph above.
Co-authored-by: Stephanie Wang <swang@cs.berkeley.edu>
| # target_utilization is 0.8, it would resize the cluster to 13. This fraction | ||
| # can be decreased to increase the aggressiveness of upscaling. | ||
| # This value must be less than 1.0 for scaling to happen. | ||
| # This max value allowed is 1.0, which is the most conservative setting. |
Contributor
There was a problem hiding this comment.
Suggested change
| # This max value allowed is 1.0, which is the most conservative setting. | |
| # The max value allowed is 1.0, which is the most conservative setting. |
stephanie-wang
approved these changes
Aug 28, 2020
ericl
added
the
@author-action-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.