Skip to content

[Autoscaler] Fix resource passing bug fix#10397

Merged
ericl merged 9 commits intoray-project:masterfrom
wuisawesome:autoscaler-bugfix
Aug 28, 2020
Merged

[Autoscaler] Fix resource passing bug fix#10397
ericl merged 9 commits intoray-project:masterfrom
wuisawesome:autoscaler-bugfix

Conversation

@wuisawesome
Copy link
Contributor

Why are these changes needed?

Fixes a few issues in resource passing for the new autoscaler.

  • Everything should be properly encoded json now
  • We pull out gpu/cpu/special case variables so they don't fail validation on ray.init

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@wuisawesome wuisawesome changed the title [Autoscaler] Fix resource passing bug fix [WIP][Autoscaler] Fix resource passing bug fix Aug 28, 2020
@wuisawesome
Copy link
Contributor Author

cc @edoakes

@wuisawesome wuisawesome changed the title [WIP][Autoscaler] Fix resource passing bug fix [Autoscaler] Fix resource passing bug fix Aug 28, 2020
@wuisawesome wuisawesome added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 28, 2020
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 28, 2020
@ericl
Copy link
Contributor

ericl commented Aug 28, 2020

Please fix the comment before merging.

Co-authored-by: Eric Liang <ekhliang@gmail.com>
@wuisawesome wuisawesome removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 28, 2020
@ericl ericl merged commit b1f3c9e into ray-project:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants