Skip to content

[Tests] Enable large test #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkooo567 merged 5 commits into from
Aug 30, 2020
Merged

[Tests] Enable large test #10391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
597ff7a
Enable large tests.
rkooo567 Aug 28, 2020
5b0f55a
Lint.
rkooo567 Aug 28, 2020
2c1a5aa
Fix issue.
rkooo567 Aug 28, 2020
ab62ce1
Skip all tests.
rkooo567 Aug 29, 2020
07b0f7b
Merge branch 'master' into enable-large-test
rkooo567 Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/ray/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,12 @@ py_test_module_list(

py_test_module_list(
files = [
"test_stress_faiure.py",
"test_stress_failure.py",
"test_failure.py"
],
size = "large",
extra_srcs = SRCS,
# TODO(ekl) enable again once we support direct call reconstruction
tags = ["exclusive", "manual"],
tags = ["exclusive"],
deps = ["//:ray_lib"],
)

Expand Down
19 changes: 3 additions & 16 deletions python/ray/tests/test_stress_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import numpy as np
import os
import pytest
import sys
import time
Expand Down Expand Up @@ -38,9 +37,7 @@ def ray_start_reconstruction(request):
cluster.shutdown()


@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
@pytest.mark.skip(reason="Failing with new GCS API on Linux.")
def test_simple(ray_start_reconstruction):
plasma_store_memory, num_nodes, cluster = ray_start_reconstruction
# Define the size of one task's return argument so that the combined
Expand Down Expand Up @@ -87,9 +84,7 @@ def sorted_random_indexes(total, output_num):
return random_indexes


@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
@pytest.mark.skip(reason="Failing with new GCS API on Linux.")
def test_recursive(ray_start_reconstruction):
plasma_store_memory, num_nodes, cluster = ray_start_reconstruction
# Define the size of one task's return argument so that the combined
Expand Down Expand Up @@ -146,9 +141,6 @@ def single_dependency(i, arg):


@pytest.mark.skip(reason="This test often hangs or fails in CI.")
@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
def test_multiple_recursive(ray_start_reconstruction):
plasma_store_memory, _, cluster = ray_start_reconstruction
# Define the size of one task's return argument so that the combined
Expand Down Expand Up @@ -219,9 +211,6 @@ def wait_for_errors(p, error_check):


@pytest.mark.skip("This test does not work yet.")
@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
def test_nondeterministic_task(ray_start_reconstruction, error_pubsub):
p = error_pubsub
plasma_store_memory, num_nodes, cluster = ray_start_reconstruction
Expand Down Expand Up @@ -288,9 +277,7 @@ def error_check(errors):
assert cluster.remaining_processes_alive()


@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
@pytest.mark.skip(reason="Failing with new GCS API on Linux.")
@pytest.mark.parametrize(
"ray_start_object_store_memory", [10**9], indirect=True)
def test_driver_put_errors(ray_start_object_store_memory, error_pubsub):
Expand Down