[docker] Run profiling without sudo#10388
Merged
rkooo567 merged 4 commits intoray-project:masterfrom Aug 29, 2020
Merged
Conversation
rkooo567
approved these changes
Aug 28, 2020
python/ray/utils.py
Outdated
|
|
||
| def get_user(): | ||
| try: | ||
| return pwd.getpwuid(os.getuid())[0] |
Contributor
There was a problem hiding this comment.
Seems like pwd.getpwuid returns named tuple (https://www.geeksforgeeks.org/pwd-module-in-python/)? Can you just use the name instead of index?
rkooo567
added
the
@author-action-required
ijrsvt
removed
the
@author-action-required
Contributor
|
@ijrsvt It seems like it fails tons of Windows tests. |
rkooo567
added
the
@author-action-required
ijrsvt
removed
the
@author-action-required
Contributor
Author
|
@rkooo567 Ah, looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sudo is not necessary in docker when the current user is
root. This PR only usessudofor profiling when the user is notroot.Related issue number
Checks
scripts/format.shto lint the changes in this PR.