Skip to content

Conversation

@simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Aug 27, 2020

Why are these changes needed?

This PR updates the theme for use Sphinx Book Theme. A full rendering can be found here

Note:

  • Breadcrumbs are gone.

Checks

Comment on lines +223 to +245
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should replace our custom "open an issue" button.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice >:)

@simon-mo
Copy link
Contributor Author

Note: We need to wait for executablebooks/sphinx-book-theme#198 to be merged and released.

@ericl
Copy link
Contributor

ericl commented Aug 28, 2020

image
image

@simon-mo several of the rllib tables look funny in the new theme, are there are fixes you can make to the config to make them look more compact?

@richardliaw
Copy link
Contributor

I think the fix there is to do it via the scss; could look into it later this weekend.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO before merge:

  1. fix the tables as mentioned by eric
  2. make sure centering works

We may want to just override the scss file with the corresponding changes for 1.0.

@simon-mo
Copy link
Contributor Author

simon-mo commented Sep 8, 2020

@richardliaw @ericl I updated the centering and table.

Image Centering

image

Table Compact

image

@richardliaw
Copy link
Contributor

image
last nit here @simon-mo

@simon-mo simon-mo added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 8, 2020
@simon-mo simon-mo merged commit 5a38a76 into ray-project:master Sep 8, 2020
@bveeramani bveeramani mentioned this pull request Aug 7, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants