-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[Doc] Use sphinx_book_theme #10379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Use sphinx_book_theme #10379
Conversation
doc/source/conf.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should replace our custom "open an issue" button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice >:)
|
Note: We need to wait for executablebooks/sphinx-book-theme#198 to be merged and released. |
|
@simon-mo several of the rllib tables look funny in the new theme, are there are fixes you can make to the config to make them look more compact? |
|
I think the fix there is to do it via the scss; could look into it later this weekend. |
richardliaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO before merge:
- fix the tables as mentioned by eric
- make sure centering works
We may want to just override the scss file with the corresponding changes for 1.0.
020f776 to
51699b1
Compare
|
@richardliaw @ericl I updated the centering and table. Image CenteringTable Compact |
|
|





Why are these changes needed?
This PR updates the theme for use Sphinx Book Theme. A full rendering can be found here
Note:
Checks
scripts/format.shto lint the changes in this PR.