Fix docs - atexit is not called when you ray.kill() an actor#10367
Merged
edoakes merged 2 commits intoray-project:masterfrom Aug 28, 2020
Merged
Fix docs - atexit is not called when you ray.kill() an actor#10367edoakes merged 2 commits intoray-project:masterfrom
edoakes merged 2 commits intoray-project:masterfrom
Conversation
rkooo567
reviewed
Aug 27, 2020
Contributor
rkooo567
left a comment
rkooo567
left a comment
There was a problem hiding this comment.
Maybe we should explain when atexit is called? The change makes sense, but it looks a little awkward as a reader.
rkooo567
added
the
@author-action-required
edoakes
removed
the
@author-action-required
Collaborator
Author
|
@rkooo567 I improved the docs, PTAL |
rkooo567
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.