[Tune] Synchronous Mode for PBT#10283
Merged
richardliaw merged 13 commits intoray-project:masterfrom Aug 31, 2020
Merged
Conversation
krfricke
reviewed
Aug 24, 2020
Contributor
krfricke
left a comment
There was a problem hiding this comment.
Just a question on the exploitation in synchronous mode, other than that it looks fine.
| trial.experiment_tag = new_tag | ||
| trial_executor.start_trial( | ||
| trial, new_state.last_checkpoint, train=False) | ||
| trial.on_checkpoint(new_state.last_checkpoint) |
Contributor
There was a problem hiding this comment.
Doesn't the exploiting trial still need to restore the state from the (new state) last checkpoint? I.e. why is there a distinction between synchronous and non-synchronous mode here, and why is on_checkpoint called in sync mode?
Contributor
There was a problem hiding this comment.
^ maybe leave a note about this
Contributor
Author
There was a problem hiding this comment.
Added a comment. If the trial is paused, we don't want to start it and then pause it again. We can just do on_checkpoint to update the most recent checkpoint, and when it gets started again, it will use the new checkpoint.
richardliaw
reviewed
Aug 25, 2020
richardliaw
reviewed
Aug 25, 2020
richardliaw
reviewed
Aug 25, 2020
richardliaw
approved these changes
Aug 31, 2020
richardliaw
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Enable:
Related issue number
Checks
scripts/format.shto lint the changes in this PR.