Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Cover cpplint for src/ray/object_manager/plasma #50729

Open
CheyuWu opened this issue Feb 19, 2025 · 1 comment
Open

[core] Cover cpplint for src/ray/object_manager/plasma #50729

CheyuWu opened this issue Feb 19, 2025 · 1 comment
Assignees
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability

Comments

@CheyuWu
Copy link
Contributor

CheyuWu commented Feb 19, 2025

Description

As part of the initiative to introduce cpplint into the pre-commit hook, we are gradually cleaning up C++ folders to ensure compliance with code style requirements. This issue focuses on cleaning up src/ray/object_manager/plasma.

Goal

  • Ensure all .h and .cc files in src/ray/object_manager/plasma comply with cpplint rules.
  • Address or suppress all cpplint warnings.

Steps to Complete

  • Checkout the latest main branch and install the pre-commit hook.
  • Manually modify all C++ files in src/ray/object_manager/plasma to trigger cpplint (e.g., by adding a newline).
  • Run git commit to trigger cpplint and identify issues.
  • Fix the reported issues or suppress them using clang-tidy if necessary.

This is a sub issue from #50583

@dentiny
Copy link
Contributor

dentiny commented Feb 20, 2025

Thanks!

@dentiny dentiny added enhancement Request for new feature and/or capability core Issues that should be addressed in Ray Core labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability
Projects
None yet
Development

No branches or pull requests

2 participants