[core] Cover cpplint for all C++ folders

[dentiny]

Description

In PR, I introduce cpplint into precommit hook, so we could detect certain invalid usage before it's merged into main branch.

We plan to do it in a gradual style, basically folder by folder, and finally make sure all C++ folders are covered.
Considering cpplint only checks on changed files, you need to manually trigger a check by intentionally change a file, could follow the steps:

• Checkin the latest main branch, and install precommit hook
• Manually make some changes for all the files under a certain folder (see script below)
• Commit your changes, so cpplint is triggered and able to detect invalid usage
• Fix any issues you've seen, if you think it valid, you could suppress warnings via https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics
• After all warnings have been addressed or suppressed, add the clean folder into precommit hook

Folders to clean up can be roughly broken down into:

• (assigned) https://github.com/ray-project/ray/tree/master/src/ray/stats
• (assigned) https://github.com/ray-project/ray/tree/master/src/ray/rpc
• (assigned) (pretty small) https://github.com/ray-project/ray/tree/master/src/ray/raylet_client
• (assigned) https://github.com/ray-project/ray/tree/master/src/ray/raylet/scheduling
• (assigned) https://github.com/ray-project/ray/tree/master/src/ray/raylet (not include scheduling folder above)
• https://github.com/ray-project/ray/tree/master/src/ray/pubsub
• (assiged) https://github.com/ray-project/ray/tree/master/src/ray/object_manager/plasma
• https://github.com/ray-project/ray/tree/master/src/ray/object_manager (not include plasma folder above)
• (assigned) (pretty small) https://github.com/ray-project/ray/tree/master/src/ray/internal
• https://github.com/ray-project/ray/tree/master/src/ray/gcs/gcs_server
• https://github.com/ray-project/ray/tree/master/src/ray/gcs (not include gcs_server folder above)
• https://github.com/ray-project/ray/tree/master/src/ray/core_worker/transport
• https://github.com/ray-project/ray/tree/master/src/ray/core_worker (not include transport folder above)
• https://github.com/ray-project/ray/tree/master/src/ray/common

Feel free to reach out to me if you have any questions!

Use case

Example script to change all C++ files under the given folder

import os

def add_newline_to_files(directory):
    # Walk through all files in the directory
    for root, dirs, files in os.walk(directory):
        for file in files:
            file_path = os.path.join(root, file)
            if not file_path.endswith(".h") and not file_path.endswith(".cc"):
                continue

            # Skip directories, only process files
            if os.path.isfile(file_path):
                with open(file_path, 'a') as f:
                    # Add newline if file is not empty and doesn't already end with one
                    f.seek(0, os.SEEK_END)
                    f.write('\n')
                print(f"Added newline to: {file_path}")

# Example usage
directory = "<your-directory>"
add_newline_to_files(directory)

[CheyuWu]

Hi @dentiny, I can help with this.

[dentiny]

Hi @dentiny, I can help with this.

hi @CheyuWu thank you so much for the help! Could you please create a subissue which records which part you want to work on, and link to the main thread?

[CheyuWu]

@dentiny OK, No problem. Thx

[CheyuWu]

I used the following command:

cpplint \
  --filter=-whitespace/line_length,\
-build/c++11,\
-build/c++14,\
-build/c++17,\
-readability/braces,\
-whitespace/indent_namespace,\
-runtime/int,\
-runtime/references,\
-build/include_order \
  src/ray/SOME_DIR/*.h \
  src/ray/SOME_DIR/*.cc

to check the cpplint rules. It might be helpful for other contributors.