Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging] Use 'warnings.warn' appropriately #12060

Open
richardliaw opened this issue Nov 17, 2020 · 9 comments
Open

[logging] Use 'warnings.warn' appropriately #12060

richardliaw opened this issue Nov 17, 2020 · 9 comments
Labels
enhancement Request for new feature and/or capability fix-error-msg This issue has a bad error message that should be improved. good-first-issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P2 Important issue, but not time-critical
Milestone
Better Error Mess...

Comments

@richardliaw
Copy link
Contributor

richardliaw commented Nov 17, 2020 •
edited
Loading

Describe your feature request

Throughout our codebase, we don't use warnings.warn and rather rely on logger.warn to inform users of possible negative outcomes.

Instead, we should use warnings.warn appropriately:

https://docs.python.org/2/howto/logging.html#when-to-use-logging
@richardliaw richardliaw added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 17, 2020
@richardliaw richardliaw changed the title [logging] Use 'warnings'warn [logging] Use 'warnings.warn' appropriately Nov 17, 2020
@richardliaw richardliaw added good-first-issue Great starter issue for someone just starting to contribute to Ray P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 17, 2020
@richardliaw richardliaw added this to the Better Error Messages milestone Nov 17, 2020
@richardliaw richardliaw mentioned this issue Nov 18, 2020
Open
@shril
Copy link

shril commented Dec 11, 2020

Hi, @richard4912 can I go ahead with the PR for this issue?
I'll document the requirements and list of file changes once you give me a green signal.

@richardliaw
Copy link
Contributor Author

richardliaw commented Dec 12, 2020 via email

@shril
Copy link

shril commented Dec 12, 2020 •
edited
Loading

@richardliaw on it.

@richardliaw
Copy link
Contributor Author

richardliaw commented Dec 12, 2020 via email

@shril
Copy link

shril commented Dec 12, 2020

My bad, updated.

@ericl ericl added the fix-error-msg This issue has a bad error message that should be improved. label Dec 31, 2020
@ofey404
Copy link
Contributor

ofey404 commented May 20, 2022 •
edited
Loading

Is there anybody working on it?

@scottsun94 scottsun94 added the observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling label Oct 17, 2022
@scottsun94
Copy link
Contributor

@shril Is it already fixed?

@rkooo567
Copy link
Contributor

I don't think it is fixed.

@scottsun94
Copy link
Contributor

@ofey404 Do you want to work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for new feature and/or capability fix-error-msg This issue has a bad error message that should be improved. good-first-issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P2 Important issue, but not time-critical
Projects
None yet
Milestone
Better Error Messages
Development

No branches or pull requests
6 participants
@ericl @richardliaw @scottsun94 @shril @rkooo567 @ofey404