[Config] Standardize quoted resource values in sample manifests. by kash2104 · Pull Request #4339 · ray-project/kuberay

kash2104 · 2026-01-04T14:45:56Z

Why are these changes needed?

Currently, resource values (e.g. cpu, memory) in sample Kubernetes manifests are inconsistent: some are quoted as strings, while others are not.

This PR standardizes all sample manifest files to use double-quoted ("") resource values.

Related issue number

Closes #4335

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

kash2104 · 2026-01-05T01:09:55Z

@CheyuWu Would love a review.

Future-Outlier

Hi, plz update these files too, thank you.
also cc @cheyu @justinyeh1995 @400Ping to take a look.

Missing Files in PR

1. Volcano Queue spec (capability field)

File	Lines	Current	Should be
`ray-cluster.volcano-scheduler-queue.yaml`	8-9	`cpu: 4`, `memory: 6Gi`	`cpu: "4"`, `memory: "6Gi"`
`ray-job.volcano-scheduler-queue.yaml`	8-9	`cpu: 4`, `memory: 6Gi`	`cpu: "4"`, `memory: "6Gi"`

2. Head Group resources - memory not quoted

File	Lines	Current	Should be
`ray-cluster.tpu-v6e-singlehost.yaml`	18, 21	`memory: 40G`	`memory: "40G"`
`ray-cluster.tpu-v6e-16-multihost.yaml`	18, 21	`memory: 40G`	`memory: "40G"`
`ray-cluster.tpu-v4-multihost.yaml`	21, 22, 25, 26	`ephemeral-storage: 20Gi`, `memory: 40G`, `ephemeral-storage: 10Gi`, `memory: 40G`	add quotes
`ray-cluster.tpu-v4-singlehost.yaml`	21	`ephemeral-storage: 20Gi`	`ephemeral-storage: "20Gi"`
`ray-cluster.external-redis.yaml`	35, 38, 85, 88	`memory: 5Gi`, `memory: 2Gi`, `memory: 1Gi`, `memory: 1Gi`	add quotes
`ray-cluster.external-redis-uri.yaml`	35, 38, 85, 88	same as above	add quotes

3. RayJob head group

File	Lines	Current	Should be
`ray-job.tpu-v6e-256-multihost.yaml`	33	`memory: 40G`	`memory: "40G"`

kash2104 · 2026-01-05T18:11:24Z

Have updated the requested files.

justinyeh1995

I think there are more to be addressed here.

I've spotted them in VSCode via

my suggestion is to update it either with VSCode (click the .* button to enable regex mode, **/*.yaml for files to include) or
use find + sed for the same purpose if you're not using VSCode.

CheyuWu · 2026-01-06T16:35:19Z

ray-operator/config/samples/ray-data-image-resize/ray-data-image-resize-gcsfusecsi-job.yaml

  rayClusterSpec:
    headGroupSpec:
      rayStartParams:
        disable-usage-stats: 'true'


One small follow-up I noticed: besides cpu and memory, there are also some non-resource values still using single quotes (').

Since this PR aims to standardize quoting style, would it make sense to also convert those to double quotes (") for consistency across all sample manifests?

It's not just about params. I noticed the same thing with annotations as well.

Good point, Do you think it makes sense to include those changes here as well, or would you prefer handling them in a separate PR?

Would be ideal if we move that to a separate PR since we will changing the production files.

kash2104 · 2026-01-06T16:53:46Z

I think there are more to be addressed here.

I've spotted them in VSCode via
my suggestion is to update it either with VSCode (click the .* button to enable regex mode, **/*.yaml for files to include) or use find + sed for the same purpose if you're not using VSCode.

@justinyeh1995 As asked in the issue proposal, only the changes needs to be made in the sample files to avoid behavioural change in production. So the changes have been made to files present in ray-operator/config/samples folder only.

CheyuWu · 2026-01-06T17:00:20Z

I think there are more to be addressed here.
I've spotted them in VSCode via

my suggestion is to update it either with VSCode (click the .* button to enable regex mode, **/*.yaml for files to include) or use find + sed for the same purpose if you're not using VSCode.

@justinyeh1995 As asked in the issue proposal, only the changes needs to be made in the sample files to avoid behavioural change in production. So the changes have been made to files present in ray-operator/config/samples folder only.

Hi @justinyeh1995 I think we can open a new issue to address the problem
WDYT?

justinyeh1995 · 2026-01-06T17:16:00Z

I think there are more to be addressed here.
I've spotted them in VSCode via

my suggestion is to update it either with VSCode (click the .* button to enable regex mode, **/*.yaml for files to include) or use find + sed for the same purpose if you're not using VSCode.

@justinyeh1995 As asked in the issue proposal, only the changes needs to be made in the sample files to avoid behavioural change in production. So the changes have been made to files present in ray-operator/config/samples folder only.

Ahh, I see. This makes sense. Let me check again.

justinyeh1995 · 2026-01-06T17:17:02Z

I think there are more to be addressed here.
I've spotted them in VSCode via

my suggestion is to update it either with VSCode (click the .* button to enable regex mode, **/*.yaml for files to include) or use find + sed for the same purpose if you're not using VSCode.

@justinyeh1995 As asked in the issue proposal, only the changes needs to be made in the sample files to avoid behavioural change in production. So the changes have been made to files present in ray-operator/config/samples folder only.

Hi @justinyeh1995 I think we can open a new issue to address the problem WDYT?

Sounds good to me!

kash2104 · 2026-01-06T17:18:17Z

@justinyeh1995 Any more changes required which lie within the scope of this issue?

justinyeh1995 · 2026-01-07T01:26:15Z

ray-operator/config/samples/ray-cluster.custom-head-service.yaml

          custom-label: custom-ray-head-service-label
        annotations:
-          custom-annotation: custom-ray-head-service-annotation
+          custom-annotation: "custom-ray-head-service-annotation"


nit: revert this back to unquoted as the string is unambiguous and it is a more common pattern.

justinyeh1995

LGTM!

Used (cpu|memory|storage|ephemeral-storage|nvidia\.com/gpu):\s+(\d+[KMGTPEmi]i?b?)\s*$ to check for cpu: 500m and etc cases.

Used (cpu|memory|storage|ephemeral-storage|nvidia\.com/gpu):\s+(\d+)\s*$ to check for cpu: 4 cases

Thanks

Future-Outlier

cursor review

Future-Outlier · 2026-01-07T04:14:41Z

cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

Future-Outlier

LGTM, thank you!

Future-Outlier · 2026-01-07T12:48:49Z

cc @rueian to merge

CheyuWu

LGTM

kash2104 force-pushed the issue-4335 branch from 0213241 to 1e1eb75 Compare January 4, 2026 17:00

Future-Outlier added this to @Future-Outlier's kuberay project Jan 5, 2026

Future-Outlier moved this to can be merged in @Future-Outlier's kuberay project Jan 5, 2026

Future-Outlier reviewed Jan 5, 2026

View reviewed changes

Future-Outlier moved this from can be merged to In Progress in @Future-Outlier's kuberay project Jan 5, 2026

CheyuWu self-requested a review January 5, 2026 13:33

kash2104 force-pushed the issue-4335 branch from 1e1eb75 to 01511bf Compare January 5, 2026 16:50

justinyeh1995 reviewed Jan 6, 2026

View reviewed changes

CheyuWu reviewed Jan 6, 2026

View reviewed changes

justinyeh1995 reviewed Jan 7, 2026

View reviewed changes

chore: Use double quoted resource values in sample manifest files.

cd7511f

kash2104 force-pushed the issue-4335 branch from 01511bf to cd7511f Compare January 7, 2026 01:39

justinyeh1995 approved these changes Jan 7, 2026

View reviewed changes

Future-Outlier reviewed Jan 7, 2026

View reviewed changes

cursor bot reviewed Jan 7, 2026

View reviewed changes

Future-Outlier approved these changes Jan 7, 2026

View reviewed changes

Future-Outlier moved this from In Progress to can be merged in @Future-Outlier's kuberay project Jan 7, 2026

CheyuWu mentioned this pull request Jan 7, 2026

[Config] Standardize quoting style in Kubernetes manifests #4353

Open

2 tasks

CheyuWu approved these changes Jan 7, 2026

View reviewed changes

rueian approved these changes Jan 8, 2026

View reviewed changes

rueian merged commit 3adcb43 into ray-project:master Jan 8, 2026
29 checks passed

github-project-automation bot moved this from can be merged to Done in @Future-Outlier's kuberay project Jan 8, 2026

DejusDevspace mentioned this pull request Jan 10, 2026

[Config]: standardize quoting style in Kubernetes manifests (#4353) #4359

Open

4 tasks

JiangJiaWei1103 mentioned this pull request Jan 12, 2026

Add RayService extra dependency example #4362

Open

Conversation

kash2104 commented Jan 4, 2026

Why are these changes needed?

Related issue number

Checks

Uh oh!

kash2104 commented Jan 5, 2026

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Missing Files in PR

1. Volcano Queue spec (capability field)

2. Head Group resources - memory not quoted

3. RayJob head group

Uh oh!

kash2104 commented Jan 5, 2026

Uh oh!

justinyeh1995 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheyuWu Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

kash2104 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

CheyuWu Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

kash2104 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

kash2104 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CheyuWu commented Jan 6, 2026

Uh oh!

justinyeh1995 commented Jan 6, 2026

Uh oh!

justinyeh1995 commented Jan 6, 2026

Uh oh!

kash2104 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinyeh1995 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

justinyeh1995 left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier commented Jan 7, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier commented Jan 7, 2026

Uh oh!

CheyuWu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinyeh1995 left a comment •

edited

Loading

kash2104 commented Jan 6, 2026 •

edited

Loading

kash2104 commented Jan 6, 2026 •

edited

Loading