[Autoscaler] validate idleTimeoutSeconds for AutoscalerOptions #4267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alimaazamat <[email protected]>
alimaazamat
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
alimaazamat
changed the title
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
cc @troychiu @machima @AndySung320
to help, thank you!
Signed-off-by: alimaazamat <[email protected]>
alimaazamat
force-pushed
the
idleTimeoutSecondsValidation
branch
from
64340e3 to
b540901
Compare
rueian
approved these changes
Dec 16, 2025
Future-Outlier
approved these changes
Dec 16, 2025
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
thank you! cc @rueian to merge.
github-project-automation
bot
moved this from In Progress
to Done
in @Future-Outlier's kuberay project
Future-Outlier
moved this from Done
to In Progress
in @Future-Outlier's kuberay project
Future-Outlier
moved this from In Progress
to Done
in @Future-Outlier's kuberay project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#4162 (comment)
Since IdleTimeoutSeconds validation for Autoscaler V2 was added for workergroupspec, we also need IdleTimeoutSeconds validation for Autoscaler.options.
Related issue number
#2561
Checks