Skip to content

[Chore] Remove an unused variable in volcano scheduler #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rueian merged 1 commit into from
Nov 25, 2025
Merged

[Chore] Remove an unused variable in volcano scheduler #4223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ray-operator/controllers/ray/batchscheduler/volcano/volcano_scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
)

const (
PodGroupName = "podgroups.scheduling.volcano.sh"
pluginName = "volcano"
QueueNameLabelKey = "volcano.sh/queue-name"
NetworkTopologyModeLabelKey = "volcano.sh/network-topology-mode"
Expand Down Expand Up @@ -87,10 +86,11 @@ func (v *VolcanoBatchScheduler) handleRayJob(ctx context.Context, rayJob *rayv1.
}

func getSubmitterResource(rayJob *rayv1.RayJob) corev1.ResourceList {
if rayJob.Spec.SubmissionMode == rayv1.K8sJobMode {
switch rayJob.Spec.SubmissionMode {
case rayv1.K8sJobMode:
submitterTemplate := common.GetSubmitterTemplate(&rayJob.Spec, rayJob.Spec.RayClusterSpec)
return utils.CalculatePodResource(submitterTemplate.Spec)
} else if rayJob.Spec.SubmissionMode == rayv1.SidecarMode {
case rayv1.SidecarMode:
submitterContainer := common.GetDefaultSubmitterContainer(rayJob.Spec.RayClusterSpec)
containerResource := submitterContainer.Resources.Requests
for name, quantity := range submitterContainer.Resources.Limits {
Expand All @@ -99,8 +99,9 @@ func getSubmitterResource(rayJob *rayv1.RayJob) corev1.ResourceList {
}
}
return containerResource
default:
return corev1.ResourceList{}
}
return corev1.ResourceList{}
}

func getAppPodGroupName(object metav1.Object) string {
Expand Down
Loading