Skip to content

[RayCluster] Add more context why we don't recreate head Pod for RayJob #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin85421 merged 1 commit into from
Nov 4, 2025
Merged

[RayCluster] Add more context why we don't recreate head Pod for RayJob #4175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ray-operator/controllers/ray/raycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,17 @@ func (r *RayClusterReconciler) reconcilePods(ctx context.Context, instance *rayv
} else if len(headPods.Items) == 0 {
originatedFrom := utils.GetCRDType(instance.Labels[utils.RayOriginatedFromCRDLabelKey])
if originatedFrom == utils.RayJobCRD {
// Recreating the head Pod if the RayCluster created by RayJob is provisioned doesn't help RayJob.
//
// Case 1: GCS fault tolerance is disabled
//
// In this case, the worker Pods will be killed by the new head Pod when it is created, so the new Ray job will not be running in
// a "provisioned" cluster.
//
// Case 2: GCS fault tolerance is enabled
//
// In this case, the worker Pods will not be killed by the new head Pod when it is created, but the submission ID has already been
// used by the old Ray job, so the new Ray job will fail.
if meta.IsStatusConditionTrue(instance.Status.Conditions, string(rayv1.RayClusterProvisioned)) {
logger.Info(
"reconcilePods: Found 0 head Pods for a RayJob-managed RayCluster; skipping head creation to let RayJob controller handle the failure",
Expand Down
Loading