[Refactor] Consolidate duplicate test utilities for maintainability#4038
Merged
rueian merged 2 commits intoray-project:masterfrom Jan 1, 2026
Merged
Conversation
…e2erayservice/support.go by reusing test/support/support.go implementations to improve maintainability and reduce redundancy. Related to ray-project#3932 Signed-off-by: HSIU-CHI LIU (Tomlord) <aa123593465@gmail.com>
Contributor
Author
|
@Future-Outlier PTAL |
EagleLo
approved these changes
Sep 3, 2025
Contributor
EagleLo
left a comment
There was a problem hiding this comment.
LGTM! Suggestion: Consider a more concise PR title like "Refactor: Consolidate duplicate test utility functions" for clarity. The CI failure appears to be a flaky test unrelated to your changes.
400Ping
approved these changes
Sep 4, 2025
Member
Signed-off-by: Hsiu-Chi Liu (Tomlord) <79390871+Tomlord1122@users.noreply.github.com>
Contributor
Author
rueian
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR refactors test support files to eliminate code duplication and improve maintainability by consolidating common utility functions.
Files Modified:
•
ray-operator/test/e2eautoscaler/support.go•
ray-operator/test/e2erayservice/support.go•
ray-operator/test/e2eautoscaler/raycluster_autoscaler_test.go•
ray-operator/test/e2eautoscaler/raycluster_autoscaler_part2_test.go•
ray-operator/test/e2erayservice/rayservice_ha_test.goMain Improvements:
option[T], apply[T], options[T]) to use existing implementations in test/support/support.goconfigMapWith, file, files, mountConfigMap)Solution Details:
Before:
After:
Related issue number
Closes #3947
Checks