-
Notifications
You must be signed in to change notification settings - Fork 681
[Refactor] Consolidate duplicate test utilities for maintainability #4038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Consolidate duplicate test utilities for maintainability #4038
Conversation
…e2erayservice/support.go by reusing test/support/support.go implementations to improve maintainability and reduce redundancy. Related to ray-project#3932 Signed-off-by: HSIU-CHI LIU (Tomlord) <[email protected]>
|
@Future-Outlier PTAL |
EagleLo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Suggestion: Consider a more concise PR title like "Refactor: Consolidate duplicate test utility functions" for clarity. The CI failure appears to be a flaky test unrelated to your changes.
fscnick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Hsiu-Chi Liu (Tomlord) <[email protected]>
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Why are these changes needed?
This PR refactors test support files to eliminate code duplication and improve maintainability by consolidating common utility functions.
Files Modified:
•
ray-operator/test/e2eautoscaler/support.go•
ray-operator/test/e2erayservice/support.go•
ray-operator/test/e2eautoscaler/raycluster_autoscaler_test.go•
ray-operator/test/e2eautoscaler/raycluster_autoscaler_part2_test.go•
ray-operator/test/e2erayservice/rayservice_ha_test.goMain Improvements:
option[T], apply[T], options[T]) to use existing implementations in test/support/support.goconfigMapWith, file, files, mountConfigMap)Solution Details:
Before:
After:
Related issue number
Closes #3947
Checks