[Chore] Upgrade golangci-lint to v2.7.2 and adjust linting configurations #4007

seanlaii · 2025-08-29T01:04:43Z

Why are these changes needed?

golangci-lint v1 is no longer maintained and has reached end-of-life. To ensure code robustness and continue following Go best practices, we need to upgrade to golangci-lint v2.

This PR focuses on the configuration migration to unblock the upgrade

Migrate golangci-lint to v2.7.2 format - Update the configuration file to be compatible with golangci-lint v2 syntax and structure.
Temporarily disable problematic linters/formatters - Some linters and formatters produce new lint errors under v2. These are disabled in this PR to unblock the migration:

errorlint
gosec
govet
noctx
revive
staticcheck
testifylint
errcheck
gci

Follow-up work - The lint errors surfaced by these disabled linters will be addressed in subsequent PRs. These follow-up tasks are well-scoped and can be picked up by other contributors to parallelize the effort. The tasks are created in #4008.

Key changes include

Separation of Linters and Formatters: gofmt, goimports, and gci have been moved from the linters.enable list to the new top-level formatters.enable section, reflecting their primary role. Their settings are now under formatters.settings.
Merge of the Linters: staticcheck, stylecheck, and gosimple are merged into one linter, staticcheck.

Crucially, all custom configurations (gocyclo, gci, goimports) and specific path exclusions have been preserved and migrated to the new v2.0 schema. This upgrade ensures we leverage the latest improvements and features of golangci-lint while maintaining our established code quality standards.

For more details on the changes in v2.0, please refer to the official migration guide: https://golangci-lint.run/product/migration-guide/

Related issue number

Part of #4008

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

seanlaii

Provide the details of the change to the golangci.yml.
Migration guide: https://golangci-lint.run/docs/product/migration-guide/

seanlaii · 2025-08-29T03:47:12Z

.golangci.yml

    - unused
    - wastedassign
-    - testifylint
-  disable-all: true


Change disable-all to

linters: default: none

according to https://golangci-lint.run/docs/product/migration-guide/#lintersdisable-all.

seanlaii · 2025-08-29T03:48:27Z

.golangci.yml

    - predeclared
    - revive
    - staticcheck
-    - typecheck


typecheck is now enabled by default and cannot be disabled: https://golangci-lint.run/docs/product/migration-guide/#typecheck

seanlaii · 2025-08-29T03:50:08Z

.golangci.yml

-    require-explanation: true
-    require-specific: true
-  revive:
-    ignore-generated-header: true


According to https://golangci-lint.run/docs/product/migration-guide/#linters-settingsreviveignore-generated-header, change it to:

linters: exclusions: generated: strict

seanlaii · 2025-08-29T03:51:52Z

apiserver/Makefile

 .PHONY: lint
 lint: golangci-lint fmt vet fumpt imports ## Run the linter.
 	# exclude the SA1019 check which checks the usage of deprecated fields.
-	test -s $(GOLANGCI_LINT) || ($(GOLANGCI_LINT) run --timeout=3m --exclude='SA1019' --no-config --allow-parallel-runners)


--exclude is removed according to https://golangci-lint.run/docs/product/migration-guide/#command-line-flags; therefore, I add it in the golangci.yml.

seanlaii · 2025-08-29T03:55:59Z

scripts/lint.sh

 for dir in $dirs_to_lint; do
  pushd "$dir"
  # exclude the SA1019 check which checks the usage of deprecated fields.
-  golangci-lint run --fix --exclude-files _generated.go --exclude='SA1019' --timeout 10m0s


Added it via linters.exclusions.paths in golangci.yml.

dentiny · 2025-12-14T12:11:49Z

Hi @seanlaii , I'm wondering if there's any updates on this PR? I think it's required for golang version bump up, thanks!

seanlaii · 2025-12-14T15:38:56Z

Hi @seanlaii , I'm wondering if there's any updates on this PR? I think it's required for golang version bump up, thanks!

Got it. Thanks for the info! Will work on it today.

Signed-off-by: wei-chenglai <[email protected]>

seanlaii · 2025-12-14T19:12:06Z

Hi @Future-Outlier @rueian , please help take a look at this PR when you have a chance to unblock the golang version bump and the lint/format issue fix. Thanks!

Future-Outlier · 2025-12-15T07:15:59Z

Hi @Future-Outlier @rueian , please help take a look at this PR when you have a chance to unblock the golang version bump and the lint/format issue fix. Thanks!

thank you for pinging me, will make this PR this week's priority.

Future-Outlier

Thank you!

Future-Outlier

cc @win5923 to help if you have time, thank you!

win5923

Thanks for your hard work!

apiserver/DEVELOPMENT.md

win5923 · 2025-12-15T13:41:40Z

apiserversdk/Makefile

 lint: golangci-lint fmt vet ## Run the linter.
 	# exclude the SA1019 check which checks the usage of deprecated fields.
-	test -s $(GOLANGCI_LINT) || ($(GOLANGCI_LINT) run --timeout=3m --exclude='SA1019' --no-config --allow-parallel-runners)
+	test -s $(GOLANGCI_LINT) || ($(GOLANGCI_LINT) run --timeout=3m --allow-parallel-runners)


Not sure if there’s a specific reason for using --no-config?
cc @rueian

Future-Outlier

cc @rueian to merge, thank you!

apiserver/Makefile

scripts/lint.sh

seanlaii changed the title ~~Upgrade golangci-lint to v2.4.0 and adjust linting configurations~~ [Chore] Upgrade golangci-lint to v2.4.0 and adjust linting configurations Aug 29, 2025

seanlaii force-pushed the golangci-v2 branch 2 times, most recently from 07b155b to d2a85d9 Compare August 29, 2025 02:54

seanlaii mentioned this pull request Aug 29, 2025

[Umbrella] Upgrade golangci-lint from v1.64.8 to v2.7.2 #4008

Closed

8 tasks

seanlaii commented Aug 29, 2025

View reviewed changes

win5923 mentioned this pull request Dec 14, 2025

[Chore] Upgrade Golang version to v1.25 #4269

Merged

4 tasks

Upgrade golangci-lint to v2.4.0 and adjust linting configurations

8d4a650

Signed-off-by: wei-chenglai <[email protected]>

seanlaii force-pushed the golangci-v2 branch from d2a85d9 to 8d4a650 Compare December 14, 2025 17:13

seanlaii added 4 commits December 14, 2025 13:45

disable linters and formatters

15f858d

fix lint

349b1e2

fix makefile

c6abd1b

fix makefile

aac021e

seanlaii marked this pull request as ready for review December 14, 2025 19:08

fix config

b36b08b

seanlaii force-pushed the golangci-v2 branch from 00a5a36 to b36b08b Compare December 14, 2025 19:30

seanlaii changed the title ~~[Chore] Upgrade golangci-lint to v2.4.0 and adjust linting configurations~~ [Chore] Upgrade golangci-lint to v2.7.2 and adjust linting configurations Dec 14, 2025

Future-Outlier approved these changes Dec 15, 2025

View reviewed changes

Future-Outlier reviewed Dec 15, 2025

View reviewed changes

win5923 approved these changes Dec 15, 2025

View reviewed changes

win5923 reviewed Dec 15, 2025

View reviewed changes

apiserver/DEVELOPMENT.md Outdated Show resolved Hide resolved

win5923 reviewed Dec 15, 2025

View reviewed changes

update install link

39b8409

seanlaii force-pushed the golangci-v2 branch from d1aa29f to 39b8409 Compare December 15, 2025 15:09

Future-Outlier reviewed Dec 16, 2025

View reviewed changes

JiangJiaWei1103 reviewed Dec 18, 2025

View reviewed changes

apiserver/Makefile Outdated Show resolved Hide resolved

scripts/lint.sh Outdated Show resolved Hide resolved

add comment

177e3a0

seanlaii force-pushed the golangci-v2 branch from 6db3919 to 177e3a0 Compare December 18, 2025 14:17

rueian approved these changes Dec 20, 2025

View reviewed changes

rueian merged commit e35feba into ray-project:master Dec 20, 2025
27 checks passed

seanlaii deleted the golangci-v2 branch December 20, 2025 00:51

Future-Outlier added this to @Future-Outlier's kuberay project Dec 22, 2025

Future-Outlier moved this to In Progress in @Future-Outlier's kuberay project Dec 22, 2025

github-project-automation bot moved this from In Progress to Done in @Future-Outlier's kuberay project Dec 22, 2025

[Chore] Upgrade golangci-lint to v2.7.2 and adjust linting configurations #4007

[Chore] Upgrade golangci-lint to v2.7.2 and adjust linting configurations #4007

Uh oh!

Conversation

seanlaii commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

This PR focuses on the configuration migration to unblock the upgrade

Key changes include

Related issue number

Checks

Uh oh!

seanlaii left a comment

Choose a reason for hiding this comment

Uh oh!

seanlaii Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlaii Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlaii Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

seanlaii Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

seanlaii Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

dentiny commented Dec 14, 2025

Uh oh!

seanlaii commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanlaii commented Dec 14, 2025

Uh oh!

Future-Outlier commented Dec 15, 2025

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

win5923 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

win5923 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

seanlaii commented Aug 29, 2025 •

edited

Loading

seanlaii Aug 29, 2025 •

edited

Loading

seanlaii Aug 29, 2025 •

edited

Loading

seanlaii commented Dec 14, 2025 •

edited

Loading