[apiserver]: merge http utils (timeout) of apiserver v1/v2 #3946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchung285
commented
Aug 13, 2025
| - name: kuberay/apiserver | ||
| newName: quay.io/kuberay/apiserver | ||
| newTag: latest | ||
| # Replace NodePort with ClusterIP as we do not need to receive requests from outside the Kubernetes cluster |
Contributor
Author
There was a problem hiding this comment.
Automatically modified by make start-local-apiserver-e2e
Signed-off-by: Cheng-Yeh Chung <[email protected]>
Signed-off-by: Cheng-Yeh Chung <[email protected]>
Signed-off-by: Cheng-Yeh Chung <[email protected]>
rueian
reviewed
Aug 15, 2025
Signed-off-by: Cheng-Yeh Chung <[email protected]>
Contributor
Author
fscnick
reviewed
Aug 16, 2025
400Ping
reviewed
Aug 16, 2025
Signed-off-by: Cheng-Yeh Chung <[email protected]>
fscnick
reviewed
Aug 17, 2025
Signed-off-by: Cheng-Yeh Chung <[email protected]>
fscnick
approved these changes
Aug 17, 2025
400Ping
approved these changes
Aug 17, 2025
rueian
approved these changes
Aug 17, 2025
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Cheng-Yeh Chung <[email protected]>
Signed-off-by: Cheng-Yeh Chung <[email protected]>
Collaborator
|
LGTM |
Contributor
Author
|
@rueian reviewers have approved these changes. Would you mind take a look again? |
win5923
pushed a commit
to win5923/kuberay
that referenced
this pull request
Sep 4, 2025
…ct#3946) * fix: missing timeout deadline in context Signed-off-by: Cheng-Yeh Chung <[email protected]> * feat: merge v1/v2 RetryConfig Signed-off-by: Cheng-Yeh Chung <[email protected]> * feat: merge v1/v2 backoff logic and timeout machenism Signed-off-by: Cheng-Yeh Chung <[email protected]> * update util function Signed-off-by: Cheng-Yeh Chung <[email protected]> * naming consistency Signed-off-by: Cheng-Yeh Chung <[email protected]> * update naming in util func Signed-off-by: Cheng-Yeh Chung <[email protected]> * Update apiserversdk/proxy.go Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Cheng-Yeh Chung <[email protected]> * simplify http util Signed-off-by: Cheng-Yeh Chung <[email protected]> --------- Signed-off-by: Cheng-Yeh Chung <[email protected]> Co-authored-by: Nary Yeh <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Merge common HTTP utils (timeout) of apiserver v1/v2 into independent file to improve compatibility
Related issue number
Closes #3893
Checks