[feat][RayCluster] shorten HeadlessServiceSuffix to have more space for CR names #3101
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you split this into two PRs, one for headless service and one for RayCluster? |
rueian
force-pushed
the
less-suffix-for-more-resource-name
branch
from
cb99863 to
d67af8c
Compare
rueian
changed the title
rueian
changed the title
…or CR names Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
less-suffix-for-more-resource-name
branch
from
d67af8c to
536d17a
Compare
Sure, another PR is here: #3102 |
|
Hi @andrewsykim, We'd like to add a length validation to RayCluster names in the next release to provide non-trimmed service names for a better user experience. But the current headless service suffix for the TPU webhook, Please let me know if you have any concerns about this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, KubeRay adds different suffixes to make different services for a RayCluster. It will also trim these service names if they are too long to fit the 63-character limitation by k8s. However, the silent cut is not user-friendly as users can't easily know the resulting service names beforehand.
As a part of #3076: we are going to add a length validation to RayCluster names in v1.4 to make sure the silent cut does not take place while keeping sufficient room for the names specified by users, this PR shortens the
-headless-worker-svcsuffix to just-headless, saving 11 characters for users to use.Related issue number
#3076
Checks