[feat][kubectl-plugin] support setting ray start params #3046
+81
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
commented
Feb 13, 2025
Comment on lines
+68
to
+73
| headRayStartParams := map[string]string{ | ||
| "dashboard-host": "0.0.0.0", | ||
| } | ||
| workerRayStartParams := map[string]string{ | ||
| "metrics-export-port": "8080", | ||
| } | ||
| maps.Copy(headRayStartParams, rayClusterSpecObject.HeadRayStartParams) | ||
| maps.Copy(workerRayStartParams, rayClusterSpecObject.WorkerRayStartParams) |
There was a problem hiding this comment.
For backwards compatibility. Lmk if it's better to remove these defaults and address the TODO comment above.
|
Should we also support this for |
|
Yes that makes sense. I’ll update this PR later if no objections. |
davidxia
force-pushed
the
ray-start-params
branch
from
bbb7a6e to
08b119a
Compare
|
updated |
davidxia
force-pushed
the
ray-start-params
branch
from
08b119a to
e21ae1f
Compare
MortalHappiness
approved these changes
Feb 18, 2025
davidxia
force-pushed
the
ray-start-params
branch
from
e21ae1f to
f560437
Compare
|
rebased to fix conflicts |
davidxia
force-pushed
the
ray-start-params
branch
2 times, most recently
from
b0a76ec to
b785c3e
Compare
|
rebased again to resolve conflicts :) |
in `kubectl ray create cluster` and `kubectl ray create workergroup` commands
with new `--head-ray-start-params` and `--worker-ray-start-params` flags.
Example
```console
$ kubectl ray create cluster dxia-test --dry-run \
--head-ray-start-params dashboard-host=0.0.0.0,disable-usage-stats=true,num-cpus=0 \
--worker-ray-start-params disable-usage-stats=true | grep -A 3 'rayStartParams:'
rayStartParams:
dashboard-host: 0.0.0.0
disable-usage-stats: "true"
num-cpus: "0"
--
rayStartParams:
disable-usage-stats: "true"
metrics-export-port: "8080"
replicas: 1
```
Signed-off-by: David Xia <[email protected]>
davidxia
force-pushed
the
ray-start-params
branch
from
b785c3e to
c13ebb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
kubectl ray create clusterandkubectl ray create workergroupcommandswith new
--head-ray-start-paramsand--worker-ray-start-paramsflags.Example
This idea was originally described in this doc.
Checks