Use longer exec probe timeouts for Head pods#2353
Merged
kevin85421 merged 1 commit intoray-project:masterfrom Sep 10, 2024
Merged
Use longer exec probe timeouts for Head pods#2353kevin85421 merged 1 commit intoray-project:masterfrom
kevin85421 merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Andrew Sy Kim <[email protected]>
3 tasks
Member
Author
|
I did more testing and I'm not sure that increasing the probe timeout is actually helping. Let's hold off on this PR for now, I will do more testing and report back |
Member
Author
|
I opened a separate PR to use HTTP probes which resolves some of the issues I'm encountering with exec probes: #2360 However, HTTP probes have a limitation of checking only a single endpoint |
kevin85421
approved these changes
Sep 10, 2024
4 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a follow-up to #2264 and #2265
For the Head pod, the exec probe timeout should be higher than 2 as exec probes run 2 "wget" commands:
This PR updates the probe timeout for Head pods to 5 seconds. See #2265 (comment) for more details.
Related issue number
#2264
Checks