-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic e2e test for kubectl plugin #2287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @MortalHappiness would you mind reviewing this PR? Thanks! |
andrewsykim
reviewed
Aug 6, 2024
MortalHappiness
requested changes
Aug 6, 2024
chiayi
force-pushed
the
kubectl-plugin
branch
20 times, most recently
from
August 7, 2024 20:00
01b32cb
to
0ac64c1
Compare
Hi @andrewsykim and @MortalHappiness please take another look. Thank you! |
andrewsykim
reviewed
Aug 8, 2024
@andrewsykim @MortalHappiness I may not have enough time to review this PR. I will merge this PR if you approve the PR. Thanks! |
chiayi
force-pushed
the
kubectl-plugin
branch
6 times, most recently
from
August 8, 2024 20:36
a92d57d
to
a1cfe41
Compare
andrewsykim
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
chiayi
force-pushed
the
kubectl-plugin
branch
2 times, most recently
from
August 8, 2024 20:49
6f2b162
to
2b2a74e
Compare
kevin85421
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This adds the basic e2e test for the Kubectl Plugin directory.
Related issue number
Checks