Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic e2e test for kubectl plugin #2287

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Aug 5, 2024

Why are these changes needed?

This adds the basic e2e test for the Kubectl Plugin directory.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chiayi chiayi marked this pull request as ready for review August 5, 2024 22:20
@kevin85421
Copy link
Member

cc @MortalHappiness would you mind reviewing this PR? Thanks!

kubectl-plugin/test/e2e/kubectl_ray_test.go Outdated Show resolved Hide resolved
.github/workflows/e2e-tests.yaml Outdated Show resolved Hide resolved
@kevin85421 kevin85421 self-assigned this Aug 6, 2024
@chiayi chiayi force-pushed the kubectl-plugin branch 20 times, most recently from 01b32cb to 0ac64c1 Compare August 7, 2024 20:00
@chiayi
Copy link
Contributor Author

chiayi commented Aug 7, 2024

Hi @andrewsykim and @MortalHappiness please take another look. Thank you!

@kevin85421
Copy link
Member

@andrewsykim @MortalHappiness I may not have enough time to review this PR. I will merge this PR if you approve the PR. Thanks!

@chiayi chiayi force-pushed the kubectl-plugin branch 6 times, most recently from a92d57d to a1cfe41 Compare August 8, 2024 20:36
Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kubectl-plugin/test/e2e/kubectl_ray_test.go Show resolved Hide resolved
kubectl-plugin/test/e2e/kubectl_ray_test.go Outdated Show resolved Hide resolved
@chiayi chiayi force-pushed the kubectl-plugin branch 2 times, most recently from 6f2b162 to 2b2a74e Compare August 8, 2024 20:49
@kevin85421 kevin85421 merged commit cd239ab into ray-project:master Aug 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants