Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Upgrade envtest to latest version #1720

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

astefanutti
Copy link
Contributor

Why are these changes needed?

This PR follows up #1648, that upgrades controller-runtime to v0.16.3, so the envtest binary is also upgraded.

The installation of the envtest binaries has changed. Some context can be found at kubernetes-sigs/controller-runtime#1488.

Related issue number

Closes #1697.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@astefanutti
Copy link
Contributor Author

@kevin85421 can you please review it, thanks!

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevin85421 kevin85421 merged commit f5141ff into ray-project:master Dec 7, 2023
25 checks passed
@astefanutti astefanutti deleted the pr-07 branch December 7, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Should we upgrade envtest?
2 participants