Adding capability to create ray cluster with serve support -clean #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin85421 here is a cleaned up version of #1582 |
kevin85421
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
- I manually test this PR with https://gist.github.com/kevin85421/823d1d6c6608643150fb6bb69e20b0e7
- The K8s service for Ray Serve is created successfully.
- Both the head and the worker Pod are selected by the K8s service's selector.
|
I will merge this PR because it has been open for a long time. I will then open a follow-up PR to address some issues, such as |
4 tasks
This was referenced Jan 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a clean-up of #1582
refer to #1582
Related issue number
Checks