[Helm] Enable leader election when leaderElectionEnabled is not set (#…

…2284) Signed-off-by: kaihsun <[email protected]>
ray-project · Aug 5, 2024 · 799f073 · 799f073
1 parent 658bd9e
commit 799f073
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/helm-chart/kuberay-operator/templates/deployment.yaml b/helm-chart/kuberay-operator/templates/deployment.yaml
@@ -82,8 +82,8 @@ spec:
             {{- $argList = append $argList "--log-file-encoder" -}}
             {{- $argList = append $argList .Values.logging.fileEncoder -}}
             {{- end -}}
-            {{- if not .Values.leaderElectionEnabled -}}
-            {{- $argList = append $argList "--enable-leader-election=false" -}}
+            {{- if hasKey .Values "leaderElectionEnabled" -}}
+            {{- $argList = append $argList (printf "--enable-leader-election=%t" .Values.leaderElectionEnabled) -}}
             {{- end -}}
             {{- (printf "\n") -}}
             {{- $argList | toYaml | indent 12 }}

diff --git a/helm-chart/kuberay-operator/values.yaml b/helm-chart/kuberay-operator/values.yaml
@@ -79,7 +79,7 @@ securityContext:
     type: RuntimeDefault
 
 
-# enabled by default, disable leader election to solve k8s api timeout when leader election occur and 1 replica exist.
+# If leaderElectionEnabled is set to true, the KubeRay operator will use leader election for high availability.
 leaderElectionEnabled: true
 
 # If rbacEnable is set to false, no RBAC resources will be created, including the Role for leader election, the Role for Pods and Services, and so on.