[Converter] Add location provider override to allow customized file location; Override reserved columns stats populating logic #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation; Additional code clean-up
Zyiqin-Miranda
force-pushed
the
dev-rest-cairns
branch
from
df913a3 to
371d864
Compare
3 tasks
pdames
approved these changes
May 2, 2025
| # Safe limit ONLY considering CPU limit, typically 32 for a 8x-large worker | ||
| DEFAULT_MAX_PARALLEL_DATA_FILE_DOWNLOAD = 30 | ||
|
|
||
| DEFAULT_ICEBERG_NAMESPACE = "default" |
Member
There was a problem hiding this comment.
What do you think about recycling the exising DEFAULT_NAMESPACE in deltacat/constansts.py and changing its current value from "DEFAULT" to "default"? (I have the same change already staged in my workspace, to standardize on existing lowercase conventions for default names)
Member
Author
There was a problem hiding this comment.
Reusing same constant sounds good, merging this PR in first and addressing in next PR #542
rnapark
pushed a commit
to rnapark/deltacat
that referenced
this pull request
Aug 17, 2025
…ocation; Additional code clean-up (ray-project#524) Co-authored-by: Miranda <yiqin121@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two additional features for customized converter job options, mainly:
Note this change does not directly override the Iceberg location provider implementation because currently DeltaCAT converter did not go through Iceberg write path. Instead, it rely on
UuidBlockWritePathProviderfor customized write path options.data_file_statistics_from_parquet_metadata()method override: As an workaround for injecting reserved column stats instead of breaking the current logic of getting all columns from schema.Rationale
Explain the reasoning behind the changes and their benefits to the project.
Changes
List the major changes made in this pull request.
Impact
Discuss any potential impacts the changes may have on existing functionalities.
Testing
Describe how the changes have been tested, including both automated and manual testing strategies.
If this is a bugfix, explain how the fix has been tested to ensure the bug is resolved without introducing new issues.
Regression Risk
If this is a bugfix, assess the risk of regression caused by this fix and steps taken to mitigate it.
Checklist
Unit tests covering the changes have been added
E2E testing has been performed
Additional Notes
Any additional information or context relevant to this PR.