adds working dockerfile #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdigits
reviewed
Sep 24, 2016
Dockerfile
Outdated
| FROM golang:1.7.1-onbuild | ||
| MAINTAINER Jimmy Mesta "[email protected]" | ||
|
|
||
| RUN wget https://dl.eff.org/certbot-auto -P /usr/local/sbin && \ |
There was a problem hiding this comment.
I'm guessing you were downloading certbot so you could get a real cert, but it doesn't appear to be used anywhere in the RUN stanzas.
There was a problem hiding this comment.
Removed Let's Encrypt support and using a self-signed cert only. We found that this app works well behind a LB / proxy and terminating TLS there with a valid certificate. I'm open to other suggestions though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created simple Dockerfile to run go-flashpaper in a container. To build run
docker build . -t test/flashpaperand run usingdocker run -d -p 8443:8443 test/flashpaper. The service will then be available locally at https://127.0.0.1:8443 if you are running Docker for Mac. A self-signed certificate is used for TLS.