Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lensed atom distinct changes #57

Merged
merged 4 commits into from
May 26, 2022

Conversation

Fyzu
Copy link
Collaborator

@Fyzu Fyzu commented May 24, 2022

Currently LensedAtom emits changes from the parent Atom

To resolve it, I'm adding distinct changes to the lense via property#combine

@Fyzu Fyzu requested a review from raveclassic May 24, 2022 15:17
@nx-cloud
Copy link

nx-cloud bot commented May 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 446247e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Fyzu Fyzu marked this pull request as ready for review May 24, 2022 15:33
@Fyzu
Copy link
Collaborator Author

Fyzu commented May 25, 2022

@raveclassic take a look

@raveclassic raveclassic merged commit d56fd2b into raveclassic:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants